Skip to content

CNV-66552:Mimic split screen behavior and drag-and-drop behavior in N… #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
aviavissar wants to merge 1 commit into
base: main
Choose a base branch
from
Open

CNV-66552:Mimic split screen behavior and drag-and-drop behavior in N… #159

aviavissar wants to merge 1 commit into from
+136 −71

Conversation

@aviavissar
Copy link

@aviavissar aviavissar commented Jan 26, 2026 •
edited
Loading

jira https://issues.redhat.com/browse/CNV-66552?filter=-1

#discription :Users experience frustration when attempting to resize the topology + form, dragging network objects, as snapping behavior can be unpredictable or confusing, making it harder to arrange components meaningfully.

  1. fix resize form
  2. the Unintentionally closing the form when drugging and now we can see all so the network obj details

before fix:

Video_2026-01-26_11-42-45.mp4

after fix :
https://github.com/user-attachments/assets/1783958b-c324-4142-8ebb-b0ccea116625

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 26, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 26, 2026 •
edited by openshift-ci bot
Loading

@aviavissar: This pull request references CNV-66552 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

jira https://issues.redhat.com/browse/CNV-66552?filter=-1

discription :Users experience frustration when attempting to resize the topology + form, dragging network objects, as snapping behavior can be unpredictable or confusing, making it harder to arrange components meaningfully.

1fix resize form

#2 the Unintentionally closing the form when drugging and now we can see all so the network obj details

before fix:
after fix :
https://github.com/user-attachments/assets/1783958b-c324-4142-8ebb-b0ccea116625

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 26, 2026
@openshift-ci openshift-ci bot requested review from metalice and tnisan January 26, 2026 09:35
@openshift-ci
Copy link

openshift-ci bot commented Jan 26, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aviavissar
Once this PR has been reviewed and has the lgtm label, please assign metalice for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 26, 2026
@openshift-ci
Copy link

openshift-ci bot commented Jan 26, 2026

Hi @aviavissar. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 26, 2026 •
edited by openshift-ci bot
Loading

@aviavissar: This pull request references CNV-66552 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

#jira https://issues.redhat.com/browse/CNV-66552?filter=-1

#discription :Users experience frustration when attempting to resize the topology + form, dragging network objects, as snapping behavior can be unpredictable or confusing, making it harder to arrange components meaningfully.

1fix resize form

#2 the Unintentionally closing the form when drugging and now we can see all so the network obj details

before fix:
after fix :
https://github.com/user-attachments/assets/1783958b-c324-4142-8ebb-b0ccea116625

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 26, 2026 •
edited by openshift-ci bot
Loading

@aviavissar: This pull request references CNV-66552 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

##jira https://issues.redhat.com/browse/CNV-66552?filter=-1

#discription :Users experience frustration when attempting to resize the topology + form, dragging network objects, as snapping behavior can be unpredictable or confusing, making it harder to arrange components meaningfully.

1fix resize form

#2 the Unintentionally closing the form when drugging and now we can see all so the network obj details

before fix:
after fix :
https://github.com/user-attachments/assets/1783958b-c324-4142-8ebb-b0ccea116625

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 26, 2026 •
edited by openshift-ci bot
Loading

@aviavissar: This pull request references CNV-66552 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

jira https://issues.redhat.com/browse/CNV-66552?filter=-1

#discription :Users experience frustration when attempting to resize the topology + form, dragging network objects, as snapping behavior can be unpredictable or confusing, making it harder to arrange components meaningfully.

1fix resize form

#2 the Unintentionally closing the form when drugging and now we can see all so the network obj details

before fix:
after fix :
https://github.com/user-attachments/assets/1783958b-c324-4142-8ebb-b0ccea116625

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 26, 2026 •
edited by openshift-ci bot
Loading

@aviavissar: This pull request references CNV-66552 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

jira https://issues.redhat.com/browse/CNV-66552?filter=-1

#discription :Users experience frustration when attempting to resize the topology + form, dragging network objects, as snapping behavior can be unpredictable or confusing, making it harder to arrange components meaningfully.

  1. fix resize form
  2. the Unintentionally closing the form when drugging and now we can see all so the network obj details

before fix:
after fix :
https://github.com/user-attachments/assets/1783958b-c324-4142-8ebb-b0ccea116625

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 26, 2026 •
edited by openshift-ci bot
Loading

@aviavissar: This pull request references CNV-66552 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

jira https://issues.redhat.com/browse/CNV-66552?filter=-1

#discription :Users experience frustration when attempting to resize the topology + form, dragging network objects, as snapping behavior can be unpredictable or confusing, making it harder to arrange components meaningfully.

  1. fix resize form
  2. the Unintentionally closing the form when drugging and now we can see all so the network obj details

before fix:

Video_2026-01-26_11-42-45.mp4

after fix :
https://github.com/user-attachments/assets/1783958b-c324-4142-8ebb-b0ccea116625

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@aviavissar aviavissar force-pushed the Mimic-split-screen-behavior-and-drag-and-drop-behavior-NNCP-wizard-topology-view branch from 8ce5fd0 to 895a588 Compare January 26, 2026 10:22
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 26, 2026
pcbailey
pcbailey reviewed Jan 26, 2026
View reviewed changes
Copy link

@pcbailey pcbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The design leaves the title bar visible with the wizard appearing before it. Can you place the drawer beneath the title bar?

Design doc: https://docs.google.com/document/d/1_CB2VknL427uZrbswV113CIfCGZa8OtvVyDkZUgsO54/edit?tab=t.0#heading=h.t0q1cztjdow9

@aviavissar aviavissar force-pushed the Mimic-split-screen-behavior-and-drag-and-drop-behavior-NNCP-wizard-topology-view branch from 895a588 to 7b0d191 Compare January 28, 2026 14:34
@upalatucci
Copy link

upalatucci commented Jan 30, 2026

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 30, 2026
@openshift-ci
Copy link

openshift-ci bot commented Jan 30, 2026

@aviavissar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-tests 7b0d191 link true /test e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@metalice metalice Awaiting requested review from metalice

@tnisan tnisan Awaiting requested review from tnisan

1 more reviewer

@pcbailey pcbailey pcbailey left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aviavissar @openshift-ci-robot @upalatucci @pcbailey @openshift-merge-robot